lib/commit: Don't chown objects to repo target owner
authorDan Nicholson <nicholson@endlessm.com>
Fri, 12 Oct 2018 12:18:36 +0000 (12:18 +0000)
committerAtomic Bot <atomic-devel@projectatomic.io>
Fri, 12 Oct 2018 12:34:57 +0000 (12:34 +0000)
commit43d9cac4fc4f38c18b8aa164fbbf77609e2b5b10
tree629171bbcdc88323c705696e51b2734a13a82396
parent9367a1befe045663a69265e10e0b4593068649e4
lib/commit: Don't chown objects to repo target owner

The idea is that if the process is running as root, it can change
ownership of newly written files to match the owner of the repo.
Unfortunately, it currently applies in the other direction, too - a
non-root user writing to a root owned repository. If the repo is
writable by the user but owned by root, it can still create files and
directories there, but it can't change ownership of them.

This feature comes from
https://bugzilla.gnome.org/show_bug.cgi?id=738954. As it turns out, this
feature was never completed. It only works on content objects and not
metadata objects, refs, deltas, summaries, etc. Rather than try to fix
all of those, remove the feature until someone has interest in
completing it.

Closes: #1754
Approved by: cgwalters
src/libostree/ostree-repo-commit.c
src/libostree/ostree-repo-private.h
src/libostree/ostree-repo.c